Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sales: update settings navigation for multi address #11442

Closed
wants to merge 1 commit into from

Conversation

dikd-odoo
Copy link
Contributor

Updated Sales app documentation on utilizing multiple customer addresses from [outdated] Sales app > Configuration > Settings to [updated] Accounting > Configuration > Settings.

Task: https://www.odoo.com/odoo/my-tasks/4293822

@robodoo
Copy link
Collaborator

robodoo commented Nov 21, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 21, 2024 23:49
@dikd-odoo
Copy link
Contributor Author

Hi @benderliz this PR is ready for a peer review, when you have a chance. Thank you!

@dikd-odoo dikd-odoo requested a review from benderliz November 21, 2024 23:55
Copy link
Contributor

@benderliz benderliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dikd-odoo I think this is a fair change! :D

@dikd-odoo
Copy link
Contributor Author

Thank you @benderliz!

Hi @ksc-odoo this PR is ready for a final review, when you have a chance. Thank you!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dikd-odoo -- just reviewed this PR. Nice job on this quick fix. Left an adjustment that requires your attention, to ensure the navigation is as accurate as possible. If you have any questions, don't hesitate to reach out. Once you implement the adjustment, feel free to tag this for Tech Review. Thanks! 👍

@dikd-odoo dikd-odoo force-pushed the 18.0-sales-customer-addresses-dikd branch from f53472d to c9e5692 Compare November 26, 2024 23:14
@dikd-odoo
Copy link
Contributor Author

Hi @ksc-odoo thank you for the edits and review!

Hello @samueljlieber this PR is ready for technical review, when you have a chance. Thank you!

@dikd-odoo dikd-odoo requested review from samueljlieber and a team November 26, 2024 23:25
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dikd-odoo, these changes look good, however the original task states this applies to all versions from 16. Can you please retarget this PR to 16.0 before I review?

Thanks!

@dikd-odoo dikd-odoo changed the base branch from 18.0 to 16.0 November 27, 2024 17:46
@samueljlieber samueljlieber force-pushed the 18.0-sales-customer-addresses-dikd branch from cb03a49 to d8658ed Compare November 27, 2024 18:03
@samueljlieber
Copy link
Contributor

d8658ed re-targeted the PR on 16.0 and will FWP to master

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dikd-odoo, looks good to me!
..
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants