-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sales: update settings navigation for multi address #11442
Conversation
Hi @benderliz this PR is ready for a peer review, when you have a chance. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dikd-odoo I think this is a fair change! :D
Thank you @benderliz! Hi @ksc-odoo this PR is ready for a final review, when you have a chance. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dikd-odoo -- just reviewed this PR. Nice job on this quick fix. Left an adjustment that requires your attention, to ensure the navigation is as accurate as possible. If you have any questions, don't hesitate to reach out. Once you implement the adjustment, feel free to tag this for Tech Review. Thanks! 👍
content/applications/sales/sales/send_quotations/different_addresses.rst
Outdated
Show resolved
Hide resolved
f53472d
to
c9e5692
Compare
Hi @ksc-odoo thank you for the edits and review! Hello @samueljlieber this PR is ready for technical review, when you have a chance. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dikd-odoo, these changes look good, however the original task states this applies to all versions from 16. Can you please retarget this PR to 16.0 before I review?
Thanks!
cb03a49
to
d8658ed
Compare
d8658ed re-targeted the PR on 16.0 and will FWP to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dikd-odoo, looks good to me!
..
@robodoo r+
closes #11442 Signed-off-by: Samuel Lieber (sali) <[email protected]>
Updated Sales app documentation on utilizing multiple customer addresses from [outdated] Sales app > Configuration > Settings to [updated] Accounting > Configuration > Settings.
Task: https://www.odoo.com/odoo/my-tasks/4293822